14 August 2013

Useful link: Article about proven practices for peer review by Jason Cohen

I found a very interesting article about good practice for peer review ( https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ )
I must admit,that  I am fan of pair programming and peer review.I had a some experience with that (sort of)  and it improved my code quality a lot and teach me to use design patterns, paradigms and much more in practice.

In Jason Cohen's article they described a  11 practices :
  1. Review fewer than 200–400 lines of code at a time.
  2. Aim for an inspection rate of fewer than 300–500 LOC per hour.
  3. Take enough time for a proper, slow review, but not more than 60–90 minutes.
  4. Be sure that authors annotate source code before the review begins.
  5. Establish quantifiable goals for code review and capture metrics so you can improve your processes.
  6. Use checklists, because they substantially improve results for both authors and reviewers.
  7. Verify that the defects are actually fixed.
  8. Foster a good code review culture in which finding defects is viewed positively. 
  9. Beware of the Big Brother effect.
  10. Review at least part of the code, even if you can't do all of it, to benefit from The Ego Effect.
  11. Adopt lightweight, tool-assisted code reviews.

It seems to me that good peer review should :
Developers should review fewer than 200-400 lines of code at a time.Inspection rate should be less  than 300–500 lines/hour and review should be around 1hour long per session.As during that time ,you will get best results . I agree that author of code should re-scan code before review as it helps author to re-think  about code and decisions made.  It helps find many of the defects during that time before the review even begins! As result it saves a lot of time and improve bug finding performance.

Everybody makes mistakes .Pair programming and peer review are great tools to produce very good quality code that require much less code maintenance in future. It uses more time during development but it saves a lot of time during maintenance.
I strongly recommend to read this article.

source: https://news.ycombinator.com/news
link: https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/